Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-menu): focus first element after adding new items #10005

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(ui5-menu): focus first element after adding new items #10005

wants to merge 3 commits into from

Conversation

tsanislavgatev
Copy link
Contributor

@tsanislavgatev tsanislavgatev commented Oct 10, 2024 •
edited
Loading

to do decription. WIP.

fixes: #7237

@unazko unazko self-requested a review October 10, 2024 10:23
unazko
unazko requested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@unazko unazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution is working for the main menu. We'll need to fix it for the sub-menus as well.

@tsanislavgatev
Copy link
Contributor Author

The solution is working for the main menu. We'll need to fix it for the sub-menus as well.

That was left out during the initial discussion. But the same code was added to the menu item, so the sub menus are also handled.

unazko
unazko requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@unazko unazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution works.
There are lint errors that needs to be fixed though.

packages/main/src/Menu.ts Outdated Show resolved Hide resolved
nnaydenow
nnaydenow previously requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@nnaydenow nnaydenow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking unti: #10070

@nnaydenow nnaydenow dismissed their stale review October 22, 2024 13:53

Menu tests are fixed and this PR no longer need to be blocked

@tsanislavgatev
Copy link
Contributor Author

New approach implementing, dont merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unazko unazko unazko approved these changes

@nnaydenow nnaydenow nnaydenow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui5-menu | Accessibility]: Focus not shifting to the first element when the menu has dynamic content
3 participants
@tsanislavgatev @unazko @nnaydenow